helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

Path in deployed CTFE public key file for ephemeral TUF creation should include "ctfe" to correctly hint as to its use in TUF creation

Open LewisThomas opened this issue 1 year ago • 3 comments

https://github.com/sigstore/helm-charts/blob/b3876089c778987b29a89cee6ec14c6fd3679336/charts/scaffold/values.yaml#L82C16-L82C16

needs to be called CTFE instead of ctlog.

As per here:

https://github.com/sigstore/scaffolding/blob/2be6921bb64c02ec00e65c69b3dc41191df5f5cd/pkg/repo/repo.go#L137C11-L137C11

Slack Thread + GitHub issue likely related: https://github.com/sigstore/cosign/issues/3386 https://sigstore.slack.com/archives/C01PZKDL4DP/p1700838479395349?thread_ts=1694462110.654769&cid=C01PZKDL4DP

LewisThomas avatar Nov 29 '23 01:11 LewisThomas

@LewisThomas I also reported this here https://github.com/sigstore/scaffolding/issues/873

https://github.com/sigstore/helm-charts/pull/673 should fix this using the fallback names. Can you confirm this?

haydentherapper avatar Dec 04 '23 19:12 haydentherapper

#673 should fix this using the fallback names. Can you confirm this?

@haydentherapper I can confirm #673 fixes this.

However #673 did not update the default values of the scaffold chart, so the bug is still present when one does not override them. I've proposed a fix in #681