helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

`ctlog` is missing a dependency on `trillian`

Open mattmoor opened this issue 1 year ago • 2 comments

Description

I noticed that the Rekor chart spins up Trillian, but the ctlog chart does not.

Rekor has the following: https://github.com/sigstore/helm-charts/blob/33a3eb210f47a6a2007981e59851fb555b53e308/charts/rekor/Chart.yaml#L20-L24

However, I don't see the same in the ctlog chart: https://github.com/sigstore/helm-charts/blob/main/charts/ctlog/Chart.yaml

Version

HEAD

mattmoor avatar Sep 30 '23 22:09 mattmoor

@vaikas was this a deliberate decision re: ctlog sharding work?

bobcallaway avatar Oct 26 '23 00:10 bobcallaway

I honestly don't know because I didn't write these :) I would assume that ctlog should have a dependency on trillian, and it would just get configured differently, but maybe that's where the concern of taking a dependency on it here is and which trillian.

vaikas avatar Oct 26 '23 00:10 vaikas