fulcio icon indicating copy to clipboard operation
fulcio copied to clipboard

Every failed request is logged as an error

Open Hayden-IO opened this issue 3 years ago • 1 comments

See https://github.com/sigstore/fulcio/blob/main/pkg/server/error.go#L42, all request errors are logged as errors regardless of if it's due to the user (4xx) or server (429, 5xx). This leads to a lot of errors in the logs that are due to malformed JWTs.

We should differentiate between user errors and server errors. User errors should be at most WARN, but for JWT errors, I would remove logging entirely since there's nothing actionable to do.

Hayden-IO avatar Dec 07 '22 21:12 Hayden-IO

See https://github.com/sigstore/rekor/blob/924fb3a0a64c8785d5ce8cd908c4299126582133/pkg/types/error.go#L18 as an approach

Hayden-IO avatar Aug 08 '23 16:08 Hayden-IO