fulcio icon indicating copy to clipboard operation
fulcio copied to clipboard
verified publisher icon sigstore

Remove obsolete Issuer and Principal classes?

Open richardfan1126 opened this issue 1 year ago • 1 comments

Question

  • Given the introduction of new CiProvider in https://github.com/sigstore/fulcio/pull/1729 And the fact that all CI providers have been changed to type: ci-provider in https://github.com/sigstore/fulcio/blob/main/config/identity/config.yaml

Should we remove the obsolete Issuer and Principal classes under pkg/identity to avoid confusion?

richardfan1126 avatar Sep 06 '24 07:09 richardfan1126

Yes, we should remove these, but I would prefer to hold off until we cut a major release of Fulcio to fully remove these as I don't want to break any existing deployments.

In the meantime, we could mark these providers as deprecated.

Hayden-IO avatar Sep 09 '24 22:09 Hayden-IO