cosign
cosign copied to clipboard
Refactor + Minor Fixes in key gen and key import commands
Refactors:
- [X] Use the
ConfirmPromptfunction everywhere instead of rolling prompt implementation everywhere. - [ ] Move
pkg/cosign/common.goto internal package. - [ ] Maybe have a single function for writing + handling perms for private & public key.
Fixes:
Address https://github.com/sigstore/cosign/blob/1d224d924197d3fab3f624a5cbe27f25d934e9f2/cmd/cosign/cli/generate/generate_key_pair.go#L101 and https://github.com/sigstore/cosign/blob/1d224d924197d3fab3f624a5cbe27f25d934e9f2/cmd/cosign/cli/importkeypair/import_key_pair.go#L52
@asraa and @venafi-iw could you please clarify what the TODO precisely means ;) Is it perm locking down in the sense of doing something equivalent to chattr +i <key_file> ?
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.
This PR was closed because it has been stalled for 10 days with no activity.