cosign icon indicating copy to clipboard operation
cosign copied to clipboard

Published 20 hours ago • verified publisher icon sigstore

Review unit and integration tests

Open priyawadhwa opened this issue 3 years ago • 3 comments
trafficstars

Some things we could do here to make sure we have good test coverage:

  • [ ] Make sure unit tests are thorough
  • [ ] Reorganize integration tests (they're mostly in one big e2e_test.go file right now)
  • [ ] Make sure integration tests are thorough, ideally covering experimental features well & an OIDC flow (this might have already happened)
  • [ ] add a test for the second case in GHSA-ccxc-vr6p-4858 once the OIDC flow is in place.

priyawadhwa avatar Feb 01 '22 03:02 priyawadhwa

We should add a test for the second case in GHSA-ccxc-vr6p-4858 once the OIDC flow is in place.

znewman01 avatar Feb 21 '22 21:02 znewman01

See also: https://github.com/sigstore/fulcio/issues/368

znewman01 avatar Mar 02 '22 17:03 znewman01

Can I tag you in, @wlynch? This seems related to some of the other Sigstore work you're doing right now and I haven't been able to find much time to devote here.

znewman01 avatar Apr 25 '22 10:04 znewman01