cosign
cosign copied to clipboard
sigstore
Remove sget command
Summary
Removes the sget command for now, while the team refines the vision for the "sget" idea, how it will be manifested in code, and how we'll distribute it to users.
Ticket Link
Related to #1363
Release Note
Removes sget command
Thanks @cpanato for finding those! 🙏
I also found a handful of other spots we're using the sget command, and I removed them. Let me know if this was too heavy-handed.
Also, I left the sget Go package for now, since it's used in cosign policy init and in E2E testing. Let me know if you think we should work to remove this "sget" reference as well.
I'd honestly still rather wait here until we have a plan. I don't think it's going to take forever to get something drafted, but doing it in a rush before we've figured out what the next step is feels like a mistake.
I'd honestly still rather wait here until we have a plan. I don't think it's going to take forever to get something drafted, but doing it in a rush before we've figured out what the next step is feels like a mistake.
Agreed 💯 . Let's do that, and this PR is here if/when we want it.
Ok so for a plan, we can leave this around until the new repo is created and we've done a release from there. That way we can delete here without causing too much confusion.
Thanks @dlorenc...we already included the sget package in our go project not realizing it was possibly being removed 😳. Thanks to @imjasonh for pointing this out to us in slack.
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@dlorenc ping, possibly https://github.com/sigstore/cosign/pull/2019 first?
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.
I think we can do this now.
#2019 was merged in https://github.com/sigstore/cosign/commit/1f42a247b80d34f1deecfdf61ce8b5e3a858308b and released as part of cosign 1.12. We're on 1.13 now, so I think this is ample warning for folks to stop depending on it.
WDYT @dlorenc
@imjasonh, when we make the release of the sget in the other repo we will continue the release version of sget and do a v1.14.0 lets say or do you want to bump to another version?
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.