open-unmix-pytorch
open-unmix-pytorch copied to clipboard
Hub loader doesn't use wiener_win_len argument value
I'm not sure if this is intentional or not but the wiener_win_len
argument is not used by the hub_loader
in the following code.
# otherwise we load the separator from torchhub
else:
hub_loader = getattr(openunmix, model_str_or_path)
separator = hub_loader(
targets=targets,
device=device,
pretrained=True,
niter=niter,
residual=residual,
filterbank=filterbank,
)
To Reproduce
Call the command line with default and different --wiener-win-len
value such as 600
and the outputs will be identical.
@papahabla good catch. Are you able to provide a PR to fix this?