Andy Boothe

Results 52 comments of Andy Boothe

This just bit me and cost me an hour or two of debugging. Not the end of the world, but it would be nice to add a blurb on the...

From [above](https://github.com/awslabs/aws-serverless-java-container/issues/315#issuecomment-1197700285): I've proposed the code change in https://github.com/awslabs/aws-serverless-java-container/pull/470 and the documentation change in https://github.com/awsdocs/aws-cloudformation-user-guide/pull/1247.

No problem at all, @deki. I understand busy, and I hope you enjoyed the vacation. I've responded over on #470!

Thanks for the feedback, @pjfanning! That was an eagle-eyed code review. Regarding the other issues, I think we agree much more than we disagree. I was excited to get the...

Got it. If the goal is to stay on LTS releases, then I think the plan to publish JDK17 features as a module for 2.x makes total sense. I have...

Thank you for the (very) quick review, @pjfanning! I will get on this feedback first thing in the morning!

Thank you again for the quick review, @pjfanning! I believe I have addressed your comments in the latest commits. I did find one issue, though: at least on my machine,...

Oof. That was embarassing. I've removed the reference to the Java16 idiom `Stream#toList`. I reconfigured my IDE to use Java8 and everything else looks good, outside of the test folders...

@cowtowncoder I'm comfortable any which way you and @pjfanning want to approach, and will abide by that decision and help however I can. FWIW, I also have a Java 17...