Sergey Vlasov

So apparently there is no ISP breakout on this PCB, and even worse, at least some of the ISP pins don't seem to be connected to anything, so if this...

The `oddball/v2_1` keyboard is somewhat odd and not compatible with converters for several reasons. First, `keyboards/oddball/config.h` contains `#define USE_I2C`, but using I2C for split communications is supported only on AVR...

Adding `LTO_ENABLE=yes` to the `make` command line may make tests work on MSYS2, but apparently that's not guaranteed (basically, it relies on the LTO phase to resolve weak symbols itself...

Keychron Q11 is a split board without a VBUS detection pin, therefore it probably needs the split watchdog to handle that case — try adding this to `config.h`: ```c #define...

The problem is that without a VBUS detection pin the master side detection does not work if there is a large delay between supplying the power and actually enumerating the...

> and i dont see any sort of aliasing on this PR files-, so im pretty sure it shouldn't even compile The defaults are somewhat hidden: - `platforms/chibios/mcu_selection.mk` sets `BOARD...

#18566 has changes in 3 places: 1. Add `usbStop()` into `init_usb_driver()`. This part looks questionable — it is an initialization function, and the USB driver should be stopped at that...

The underlying LLD implementation of `usbStop()` in the Kinetis driver looks buggy: ```c void usb_lld_stop(USBDriver *usbp) { /* TODO: If in ready state then disables the USB clock.*/ if (usbp->state...

The actual implementation of `usbDisconnectBus()` is this (HAL does not add any code of its own there): ```c /* Writing to USB0->CONTROL causes an unhandled exception when USB module is...

The more important question is why `main` is even used here? The handedness options do not select which side of the keyboard is “main”/“master”, they select which side is left...