Some comments on Siren 3.0.5 (not released yet)
Did some testing on the latest Siren 3.0.5 in the unstable branch. Some comments:
-
This PR mentions it is enabling dark theme by default, but when i open it, it's still light theme.
-
This PR mentions:
Allows copying of eth1 withdrawal addressesNot sure how to do this? When I go to theValidator Managementdashboard and point to the withdrawal address, a question-mark like symbol appears, and it's not about copying the withdrawal address (same goes to the public key) (can't screenshot now because once I print screen, the question-mark like symbol will change to normal mouse cursor)
When click into the individual validator and point to the withdrawal address, the same question-mark like symbol appears, also not about copy.
- Some of the WARN logs appear in the Siren logs dashboard, but I don't think they show up in normal beacon node logs (e.g.,
journalctl)
Awesome. Thanks @chong-he
There's some more features I'd like to test if you are looking into this.
In particular this: https://github.com/sigp/siren/pull/421 <- Want to run on a testnet before making it ready for mainnet.
And also this one: https://github.com/sigp/siren/pull/422
In regards to your points....
- dark by default (I'll look into it).
- The eth1 withdrawal copy icon was added to the consolidation flow when it asks you about which validator and displays withdrawal addresses to check against. I can expand this to be more general if you think its useful. I added it there because I found myself wanted to check which address belongs to what.
- The warning logs are an issue with Lighthouse. I've fixed them here: https://github.com/sigp/lighthouse/pull/7819. We need to wait for a new lighthouse release for these to be resolved.
Thanks again for the help
* The eth1 withdrawal copy icon was added to the consolidation flow when it asks you about which validator and displays withdrawal addresses to check against. I can expand this to be more general if you think its useful. I added it there because I found myself wanted to check which address belongs to what.
I see it now, looks good. Yeah I think we can leave this as it is now.
* The warning logs are an issue with Lighthouse. I've fixed them here: [Filter dependencies from SSE logging lighthouse#7819](https://github.com/sigp/lighthouse/pull/7819). We need to wait for a new lighthouse release for these to be resolved.
I have tested and the warning logs are gone now, looking good
I will test other PRs and posted on the PR itself later