lighthouse
lighthouse copied to clipboard
sigp
Config Validation
Issue Addressed
Proposed Changes
A few changes. First, as discussed in the discord, the defaults have been removed to ensure that all expected fields are provided.
Second, I do validate that no additional values are present. However, as discussed with sproul, there are some legitimate reasons to add some for future forks. I ended up solving this by adding a small modifiable constant which allows specified optional fields to exist.
I'm doing some tests to ensure presets like SLOTS_PER_EPOCH are also disallowed, but this should also solve that problem.
Additional Info
Please provide any additional information. For example, future considerations or information useful for reviewers.
I'll do that, as well as take a look at the tests. Appreciate the review!
Alright, I fixed up the tests.
Most of the issues were simply because the validation and removal of defaults meant I had to add the missing fields in the existing configs.
For this, I ended up using the original default values to maintain the same functionality as before.
Some required checks have failed. Could you please take a look @Patchoulis? 🙏
![mergify[bot] avatar](https://avatars.githubusercontent.com/in/10562?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @Patchoulis, this pull request has been closed automatically due to 30 days of inactivity. If you’d like to continue working on it, feel free to reopen at any time.
Hi @Patchoulis, this pull request has been closed automatically due to 30 days of inactivity. If you’d like to continue working on it, feel free to reopen at any time.