lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard

Trigger sampling after gossip block is execution valid

Open dapplion opened this issue 1 year ago • 0 comments

Issue Addressed

Resolve a PeerDAS todo

Proposed Changes

Wait for a gossip block to be execution valid before triggering sampling. Otherwise, the block might have invalid transactions and trigger us to ask peers for data that does not exist. However, a proposer could still include valid blob transactions and withhold data, causing the same situation. Since gossip blocks are proposer signature valid, we have some DOS protection.

I'm 50/50 on this change being necessary, thoughts?

dapplion avatar Oct 15 '24 16:10 dapplion