lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard

Fix/remove some Electra attestation todos

Open realbigsean opened this issue 1 year ago • 1 comments

Issue Addressed

  • Removed logging about deneb attestations at the fork, current plan across clients is to just ignore them, and the logging here causes confusion
  • run a few tests for both electra and base attestation types
  • Remove a few todo's about verifying logic is correct. All of these reside in consensus/types/src/beacon_block.rs and look like they're correct. Would appreciate additional confirmation from reviewers here.

realbigsean avatar May 20 '24 18:05 realbigsean

not the best person to comment on the beacon_chain changes, but the changes to attestation, attester_slashing and the TODO removals in beacon_block look fine to me

eserilev avatar May 20 '24 21:05 eserilev

image

ethDreamer avatar May 30 '24 15:05 ethDreamer