lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard

Pass vec to range sync batch

Open dapplion opened this issue 1 year ago • 0 comments

Issue Addressed

Non-urgent clean-up possible after

  • https://github.com/sigp/lighthouse/pull/5583

This can wait for after v5.2.0

Currently we are:

  • Fetching an entire Vec of blocks in the network context
  • Constructing a stream with None terminator in sync manager
  • Batch handles each block individually

Proposed Changes

Instead, we can just pass the vec from the network context to the batch

All logic in unchanged, most of the diff is a change in indentation

dapplion avatar May 03 '24 13:05 dapplion