lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard

Will lighthouse return an empty list when fetching an expired blob?

Open zhiqiangxu opened this issue 1 year ago • 3 comments

We're talking about how should op stack deal with expired blobs here. Currently op stack was expecting an error to be returned for expired blobs. Prysm will return empty list/status=200 for expired blobs. What about lighthouse?

I've read the code for beacon/blob_sidecars/{block_id}, it seems lighthouse will also return an empty list when fetching an expired blob.

Just wanna confirm with the official team:)

zhiqiangxu avatar Apr 24 '24 01:04 zhiqiangxu

Yeah at the moment Lighthouse will also return an empty list.

I don't really like this behaviour though, because it combines the cases for (1) no blobs ever existed at this slot and (2) there were blobs at this slot but we've deleted them.

michaelsproul avatar Apr 24 '24 01:04 michaelsproul

Worth it to raise the issue in the beacon APIs specs. There has been similar discussions for the case of missed slots. Would having different HTTP status code serve your use case?

dapplion avatar Apr 29 '24 03:04 dapplion

I think so, here is how op stack is handling the response.

zhiqiangxu avatar Apr 29 '24 03:04 zhiqiangxu

I think we should just return a 404 here. I'll raise a PR.

michaelsproul avatar Aug 29 '24 23:08 michaelsproul

PR here:

  • https://github.com/sigp/lighthouse/pull/6331

michaelsproul avatar Aug 30 '24 02:08 michaelsproul

The fix will be in the next release - v6.0.0

michaelsproul avatar Sep 18 '24 00:09 michaelsproul