lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard
verified publisher icon sigp

Implement gossipsub IDONTWANT

Open jxs opened this issue 1 year ago • 4 comments

Issue Addressed

implement IDONTWANT message sending and addressing when forwarding. Follows https://github.com/libp2p/specs/pull/548

Should be reviewed after https://github.com/sigp/lighthouse/pull/5401 is merged

jxs avatar Mar 17 '24 17:03 jxs

@jxs @AgeManning I have submitted a PR to address the issue I previously mentioned. Could you please review it?

https://github.com/jxs/lighthouse/pull/4

ackintosh avatar Apr 23 '24 03:04 ackintosh

Yeah looks like you're right. We probably should have a test for this. I'll add the test and double check this corrects it. I'll push your changes to this branch

AgeManning avatar Apr 23 '24 06:04 AgeManning

thanks @ackintosh!

jxs avatar Apr 23 '24 14:04 jxs

@AgeManning @jxs I submitted a PR to address the failing tests. Could you please review it when you have a chance? 🙏

https://github.com/jxs/lighthouse/pull/5

ackintosh avatar Apr 30 '24 07:04 ackintosh

@mergifyio queue

AgeManning avatar Jul 08 '24 00:07 AgeManning

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at d46ac6c3d3b89fe1773c53776947d646c53ebdb1

mergify[bot] avatar Jul 08 '24 00:07 mergify[bot]

@mergifyio refresh

AgeManning avatar Jul 09 '24 05:07 AgeManning

refresh

✅ Pull request refreshed

mergify[bot] avatar Jul 09 '24 05:07 mergify[bot]