lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard

Remove use of ethers core

Open dospore opened this issue 1 year ago • 2 comments

Issue Addressed

Working from #5207 to begin conversion from ethers_core to alloy

Proposed Changes

Uses alloy RlpEncodable/RlpDecodable types instead of ethers_core rlp stream

Additional Info

There are many more uses of ethers_core in this repository so thought I would reduce the number of changes and potentially put more pr's in the future.

dospore avatar Feb 26 '24 03:02 dospore

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 26 '24 03:02 CLAassistant

@dospore sorry for leaving this PR open for a while, would you mind fixing conflicts?

dapplion avatar Jun 27 '24 16:06 dapplion

@dospore sorry for leaving this PR open for a while, would you mind fixing conflicts?

Yes, for sure. Ill get around this tomorrow @dapplion

dospore avatar Jul 03 '24 07:07 dospore

error: package `migrations_macros v2.2.0` cannot be built because it requires rustc 1.78.0 or newer, while the currently active rustc version is 1.77.0
Either upgrade to rustc 1.78.0 or newer, or use
cargo update [email protected] --precise ver
where `ver` is the latest version of `migrations_macros` supporting rustc 1.77.0

Is it necessary to bump diesel_migrations?

dapplion avatar Jul 10 '24 09:07 dapplion

Is it necessary to bump diesel_migrations? Yeah im not sure what happened there. Looks like my lock file got muddled up, pulled in unstable and is succeeding in running that check on 1.77.0 locally

dospore avatar Jul 14 '24 22:07 dospore

@mergify queue

michaelsproul avatar Jul 24 '24 00:07 michaelsproul

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI. Then, re-embark the pull request into the merge queue by posting the comment @mergifyio refresh on the pull request.

mergify[bot] avatar Jul 24 '24 00:07 mergify[bot]

@mergify requeue

michaelsproul avatar Jul 24 '24 00:07 michaelsproul

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

mergify[bot] avatar Jul 24 '24 00:07 mergify[bot]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 10445f31c64a795618ff858d9f402aa798c814ff

mergify[bot] avatar Jul 24 '24 00:07 mergify[bot]