lighthouse
lighthouse copied to clipboard
sigp
Update metrics.rs
related with https://github.com/sigp/lighthouse/issues/5206
i adjusted for a range up to 0.1 seconds (100ms)
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
Metrics from the original issue show that the lower resolution is not being used. Not sure @michaelsproul if you need 5ms resolution, otherwise the metric lin range could be of resolution 10ms and range up to 200ms
linear_buckets(0.01, 0.01, 20)
yeah IMO 10ms would be fine, I would also prefer less buckets (10-15, not 20)
Metrics from the original issue show that the lower resolution is not being used. Not sure @michaelsproul if you need 5ms resolution, otherwise the metric lin range could be of resolution 10ms and range up to 200ms
linear_buckets(0.01, 0.01, 20)
thank you for your review!
yeah IMO 10ms would be fine, I would also prefer less buckets (10-15, not 20)
thank you for your review! changed to 10
@DoTheBestToGetTheBest you also need to accept the CLA
what is this?
It's a contributor license agreement, it just says that you agree to license your contributions under the same license as the rest of Lighthouse (Apache 2.0). It's a bit of a bureaucratic hurdle, but only takes a second, see: https://github.com/sigp/lighthouse/pull/5215#issuecomment-1933178620.
@DoTheBestToGetTheBest you also need to accept the CLA
what is this?
At the bottom of this PR, or the direct link: https://cla-assistant.io/sigp/lighthouse?pullRequest=5215
