lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard

Clean up naming of `VariableList`/`FixedVector` on tree-states

Open michaelsproul opened this issue 1 year ago • 1 comments

Description

At the moment tree-states has a confusing mix of type aliases for the VariableList/FixedVector types. To remedy the situation I'm proposing to instead use these names:

  • VariableList/FixedVector: same as on stable, refer to types from ssz_types
  • List/Vector: unmodified milhouse type names

Alternatively, we could alias both libraries with new names:

  • TreeList/TreeVector: type aliases for milhouse types
  • FlatList/FlatVector: type aliases for ssz_types types

However I think avoiding aliases altogether is probably clearer.

michaelsproul avatar Jan 30 '24 01:01 michaelsproul

  • VariableList/FixedVector: same as on stable, refer to types from ssz_types
  • List/Vector: unmodified milhouse type names

+1

dapplion avatar Jan 30 '24 03:01 dapplion