lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard

fix(validator_client): raise soft fd limit

Open rkrasiuk opened this issue 2 years ago • 4 comments

Issue Addressed

Closes https://github.com/sigp/lighthouse/issues/3468

Proposed Changes

Attempt to raise validator client's fdlimit. OS specific behavior is described in the comments

rkrasiuk avatar Sep 30 '23 10:09 rkrasiuk

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 30 '23 10:09 CLAassistant

@dapplion upgraded the crate. re limiting this behavior - fair enough, we could raise fdlimit based on the current limit and the number of user keys loaded. alternatively, we could expose a CLI flag, that users could pass in case they hit the limit

rkrasiuk avatar Jan 19 '24 11:01 rkrasiuk

alternatively, we could expose a CLI flag, that users could pass in case they hit the limit

This feature is maximally useful when it allows users to not have to think about file limits. Adding a flag defeats the purpose, as after an error the user now has to add a new flag, might as well manually bump the file limit

dapplion avatar Jan 21 '24 08:01 dapplion

I've pushed this to v5.1.0 since it doesn't seem critical for Deneb.

paulhauner avatar Feb 15 '24 08:02 paulhauner

Pushed back to 5.2 since we want to get networking improvements in the 5.1 release out soon.

pawanjay176 avatar Mar 07 '24 11:03 pawanjay176

@mergify queue

realbigsean avatar Apr 29 '24 22:04 realbigsean

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at c8ffafb3f8e5022661020354d727b12b573b9e88

mergify[bot] avatar Apr 29 '24 22:04 mergify[bot]