lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard

WIP: Import sync committee messages into op pool

Open tthebst opened this issue 3 years ago • 3 comments

Issue Addressed

#2449

Proposed Changes

Sweep contribution in the naive pool into the op pool before producing a new block. When inserting sync contributions into the op pool, we try to aggregate with the existing contributions.

Additional Info

Should I add a test for this somewhere and am I missing sth?

tthebst avatar Sep 05 '22 18:09 tthebst

wtf you can't add a comment to an unchanged line on github....

The per_slot_task function calls self.naive_aggregation_pool.write().prune(slot) should prune also be called on naive_sync_aggregation_pool?

tthebst avatar Sep 05 '22 18:09 tthebst

Noting that the probability that a randomly selected proposer is also an aggregator on a given slot at mainnet today is 16 * 4 / 900,000. So every day this event happens 24 * 3600 / 12 * 16 * 4 / 900,000 ~ 0.5, so once every 2 days.

Might want to revisit once there's more capacity to benchmark the cost of iterating the pool on every block proposal

dapplion avatar Jan 19 '24 02:01 dapplion

Hey @tthebst do you have capacity to test this out?

dapplion avatar Jun 27 '24 08:06 dapplion