lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard

Maintain attestation subnet peers

Open pawanjay176 opened this issue 3 years ago • 1 comments

Description

Currently, for attestation subnets, we find peers in the required subnet from discovery and give it to the peer manager to dial. If we connect to all the discovered peers in that subnet then they disconnect before the attestation duty for some reason, we might get in a situation where we don't have enough peers in that subnet to publish the message.

To fix this, we could modify the maintain_sync_committee_peers function in the peer manager to also maintain peers for attestation subnets.

https://github.com/sigp/lighthouse/blob/df51a73272489fe154bd10995c96199062b6c3f7/beacon_node/lighthouse_network/src/peer_manager/mod.rs#L801

This way, we won't be affected by random disconnects by subnet peers for attestations.

pawanjay176 avatar Aug 18 '22 20:08 pawanjay176

Is this still open. I'd like to tackle this issue.

oxlime avatar Sep 13 '22 05:09 oxlime

closing this in favor of https://github.com/sigp/lighthouse/issues/2981

divagant-martian avatar Oct 20 '22 16:10 divagant-martian