lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard

Remove redundancy in the ulrs in the execution layer' config

Open divagant-martian opened this issue 2 years ago • 3 comments

Description

After removing the fallback for engines in the execution_layer crate, we don't need the secret_files and execution_endpoint to be able to hold more than one in each field. Those could be changed to be options or even mandatory fields.

The relevant code is here

divagant-martian avatar Jul 05 '22 01:07 divagant-martian

between the code example and this issue I can't tell - are you saying execution_endpoints and secret_files don't need to be vectors, and can be Options, or are you saying just builder_url should be an Option?

AndyBarnard avatar Jul 20 '22 07:07 AndyBarnard

builder_url is not related to this issue. Just execution_endpoints and secret_files. Happy to help if you want to give this a go

divagant-martian avatar Jul 22 '22 17:07 divagant-martian

ah my fork didn't have builder_endpoints as an Option, got a little mixed up there. I'll give it a go now!

AndyBarnard avatar Jul 23 '22 04:07 AndyBarnard

little checkup for whoever is interested. Still relevant to this date

divagant-martian avatar Jun 05 '23 23:06 divagant-martian