lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard

Adding lighthouse/peers methods in BeaconNodeHttpClient

Open leruaa opened this issue 3 years ago • 2 comments
trafficstars

Issue Addressed

Issue #3041

Proposed Changes

  • Add the corresponding get_lighthouse_peers() and get_lighthouse_connected_peers() methods to BeaconNodeHttpClient
  • Impl Deserialize on Peer struct and all fields structs recursively

leruaa avatar Feb 25 '22 18:02 leruaa

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 25 '22 18:02 CLAassistant

I noticed that the score is not serialized as:

"score": {
  "score": 0
}

like described in the book, but like that:

"score": {
  "RealScore": {
    "lighthouse_score": 0,
    "gossipsub_score": 0,
    "ignore_negative_gossipsub_score": false,
    "score": 0
  }
}

Do we want to keep all the score details? Maybe we could streamline to just:

"score": 0

But obviously, that another breaking change...

leruaa avatar Mar 03 '22 22:03 leruaa

Superseded by

  • https://github.com/sigp/lighthouse/pull/4937

dapplion avatar Jan 19 '24 11:01 dapplion