Clap derive

Open realbigsean opened this issue 3 years ago • 3 comments

Issue Addressed

Improves ergonomics of handling CLI flags and takes care of tracking config names in different places. This is somewhat helpful in layering config from different sources as well, which is necessary in the following PRs:

https://github.com/sigp/lighthouse/pull/2808
https://github.com/sigp/lighthouse/pull/2960

Proposed Changes

Migrate lighthouse to clap derive

Feb 07 '22 19:02 realbigsean

The CLI tests are so massive for this! Caught a bunch of issues!

Feb 08 '22 19:02 realbigsean

Script for checking out the --help diff between two lighthouse binaries: https://gist.github.com/realbigsean/3b1de807c938348fc0ba5d76709d2a37

Feb 10 '22 16:02 realbigsean

I'm going to drop the ready-for-review tags due to conflicts. Sorry about letting this one go stale, we can chat about it sometime :)

Jul 04 '22 00:07 paulhauner

closing, see

https://github.com/sigp/lighthouse/issues/5087

Jan 19 '24 02:01 realbigsean