lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard

Add attestation duty slot metric

Open pawanjay176 opened this issue 4 years ago • 4 comments

Issue Addressed

Resolves #2521

Proposed Changes

Add a metric that indicates the next attestation duty slot for all managed validators in the validator client.

pawanjay176 avatar Oct 12 '21 13:10 pawanjay176

Pending testing with high validator numbers.

pawanjay176 avatar Oct 12 '21 14:10 pawanjay176

just fyi There is a conflict now

divagant-martian avatar Oct 20 '21 14:10 divagant-martian

By default, the metric is only provided when the vc manages < 64 validators.

Provided an additional enable-high-validator-count-metrics flag for enabling the attestation duty metrics for > 64 validators. Although, this doesn't increase memory/cpu for high validator counts either (5k validators on prater).

pawanjay176 avatar Oct 20 '21 18:10 pawanjay176

Is this something we can get in a future release? Most of the other CC's have this feature. Would love to see LH have it.

Woogz-git avatar Aug 02 '22 02:08 Woogz-git

If you'd be open to resolving these conflicts @pawanjay176 I'd be happy to continue to review! I think it just fell off the radar at some point, apologies.

paulhauner avatar Nov 14 '22 05:11 paulhauner

@paulhauner Merged in unstable and tested it both with small and large validator counts. This is ready for review now.

pawanjay176 avatar Jan 25 '23 09:01 pawanjay176

Oops, didn't mean to unassign Paul, that was a fat-fingered blunder

michaelsproul avatar Feb 09 '23 06:02 michaelsproul

Lets go!

bors r+

michaelsproul avatar Feb 09 '23 21:02 michaelsproul

Build failed:

bors[bot] avatar Feb 09 '23 21:02 bors[bot]

bors retry

michaelsproul avatar Feb 09 '23 23:02 michaelsproul