Add attestation duty slot metric
Issue Addressed
Resolves #2521
Proposed Changes
Add a metric that indicates the next attestation duty slot for all managed validators in the validator client.
Pending testing with high validator numbers.
just fyi There is a conflict now
By default, the metric is only provided when the vc manages < 64 validators.
Provided an additional enable-high-validator-count-metrics flag for enabling the attestation duty metrics for > 64 validators.
Although, this doesn't increase memory/cpu for high validator counts either (5k validators on prater).
Is this something we can get in a future release? Most of the other CC's have this feature. Would love to see LH have it.
If you'd be open to resolving these conflicts @pawanjay176 I'd be happy to continue to review! I think it just fell off the radar at some point, apologies.
@paulhauner Merged in unstable and tested it both with small and large validator counts. This is ready for review now.
Oops, didn't mean to unassign Paul, that was a fat-fingered blunder
Lets go!
bors r+
bors retry
Pull request successfully merged into unstable.
Build succeeded:
- arbitrary-check
- beacon-chain-tests
- cargo-audit
- cargo-fmt
- cargo-udeps
- cargo-vendor
- check-benchmarks
- check-msrv
- clippy
- compile-with-beta-compiler
- debug-tests-ubuntu
- dockerfile-ubuntu
- doppelganger-protection-test
- ef-tests-ubuntu
- eth1-simulator-ubuntu
- execution-engine-integration-ubuntu
- merge-transition-ubuntu
- no-eth1-simulator-ubuntu
- op-pool-tests
- release-tests-ubuntu
- release-tests-windows
- slasher-tests
- state-transition-vectors-ubuntu
- syncing-simulator-ubuntu