signum-node icon indicating copy to clipboard operation
signum-node copied to clipboard

Investigate JSON creation rule for zero account as recipient

Open frankTheTank72 opened this issue 2 years ago • 3 comments

If a JSON is created we have the following check for the zero account:

grafik

In this case, the receiver is not set in the JSON message. We should check if we can remove this check, as this JSON is also used to propagate messages between nodes.

frankTheTank72 avatar Mar 03 '23 10:03 frankTheTank72

So, you potentially want to check, if something is burnt? :fire:

I have a potential solution: If recipient Id = 0 we set a flag burnt=true, so no compatibility issue then.

ohager avatar Jan 03 '24 20:01 ohager

What problems does this actually cause, and, more importantly, where is it in the code? I'm curious what this is for. Judging from @ohager's comment, it's a check to burn signa, but there's no context in this issue.

damccull avatar Jan 28 '24 13:01 damccull

yep lost the context also - sh... I think something with the node comunication ... but maybe @jjos2372 rembers it... sorry

frankTheTank72 avatar Jan 28 '24 13:01 frankTheTank72