react-snuggle icon indicating copy to clipboard operation
react-snuggle copied to clipboard

Missing tests

Open danilowoz opened this issue 7 years ago • 3 comments

Currently, we don't have any test and I really want to ensure that everything keeps working fine on the future changes and avoid bugs in the application. However, It's a great opportunity to learn and improve the skills to build tests in React.

What are we expecting?

  • [x] Choose the best suit test (Jest, chai, whatever you prefer);
  • [ ] Split the code into smaller parts;
  • [ ] 100% coverage or close that;
  • [ ] Improv the Flow type;
  • [ ] Don't change and don't remove any feature;

Cheers 🍻

danilowoz avatar Oct 02 '18 09:10 danilowoz

Will take care of this!

takethefake avatar Oct 02 '18 10:10 takethefake

I've chosen Jest + react-testing-library for testing.

I would split the rendering of the grid in a single component and the rendering of each tile in a component.

Was wondering what edge cases are extremely important with this library to create coverage with meaningful tests.

takethefake avatar Oct 02 '18 17:10 takethefake

Thanks, @takethefake, the setup is almost done. I think we can to keep this issue open and improve the tests.

To the next contributors, there is a todo list at the top of the discussion and any doubt or needs help, just message here :)

danilowoz avatar Oct 08 '18 11:10 danilowoz