lorawan icon indicating copy to clipboard operation
lorawan copied to clipboard

Closing of receive window calculations missing 4.25

Open JacoTuks opened this issue 2 years ago • 0 comments

Expected Behavior

According to The LoRa Modem Designer's guide, the duration of a preamble is (nPreamble + 4.25)*Tsym but in class-a-end-device-lorawan-mac.cc the +4.25 is omitted.

image

Actual Behavior

Both receive windows are scheduled to close too fast.

Code in question

class-a-end-device-lorawan-mac.cc

  1. m_closeFirstWindow = Simulator::Schedule (Seconds (m_receiveWindowDurationInSymbols*tSym), &ClassAEndDeviceLorawanMac::CloseFirstReceiveWindow, this); //m_receiveWindowDuration

  2. m_closeSecondWindow = Simulator::Schedule (Seconds (m_receiveWindowDurationInSymbols*tSym), &ClassAEndDeviceLorawanMac::CloseSecondReceiveWindow, this);

Specifications

  • lorawan module version: develop branch latest commit (e8f7a21)

Please let me know if I have missed something? I will happily create a pull request if you agree that this is an issue.

JacoTuks avatar Jun 09 '22 11:06 JacoTuks