react-mentions
react-mentions copied to clipboard
signavio
fix: #498 support IME with input hint along
Fixes #498
What did you change (functionally and technically)? functionally
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/signavio/react-mentions/CdG6DPXeS9eSF92EqMgv92z5H9PX
✅ Preview: https://react-mentions-git-fork-amosjin-fix-ime-with-input-hint-136c4d.vercel.app
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Codecov Report
Merging #499 (e60ad0c) into master (a2c8856) will increase coverage by
0.29%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #499 +/- ##
==========================================
+ Coverage 78.84% 79.14% +0.29%
==========================================
Files 32 32
Lines 695 700 +5
Branches 108 109 +1
==========================================
+ Hits 548 554 +6
+ Misses 146 145 -1
Partials 1 1
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/utils/applyChangeToValue.js | 91.89% <100.00%> (+4.39%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update a2c8856...e60ad0c. Read the comment docs.
I too was faced with a problem that was solved by this PR. Thank you for resolving this issue.
In my project, I applied this PR as a patch a few months ago and it has been working fine all along. So I don’t think it will be a problem to release this PR.
@tachibanayu24 Could you tell me your workaround of this problem, I don't think I can solve this unless this PR merges.
@manato-kawamura Check out the library patch-package. You can apply arbitrary patch fixes to dependencies.
@tachibanayu24 Thank you so much for your immediate reply and will try that one.
