react-mentions icon indicating copy to clipboard operation
react-mentions copied to clipboard

Added support to disable suggestion selection

Open mastrix opened this issue 4 years ago • 6 comments

Added support to disable mention suggestion, it's useful when you need to display the whole list but disable the ability to select smbdy.

Checklist (remove this list before you submit the PR)

  • Are there tests for the new code? -

Additional review hints (remove this list before you submit the PR) It shouldn't break any functionality as it's just preventing events.

mastrix avatar Oct 09 '20 11:10 mastrix

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/signavio/react-mentions/1kl66446c
✅ Preview: https://react-mentions-git-master.signavio.vercel.app

vercel[bot] avatar Oct 09 '20 11:10 vercel[bot]

Codecov Report

Merging #440 into master will decrease coverage by 0.22%. The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
- Coverage   78.87%   78.64%   -0.23%     
==========================================
  Files          31       31              
  Lines         691      693       +2     
  Branches      107      109       +2     
==========================================
  Hits          545      545              
- Misses        145      147       +2     
  Partials        1        1              
Impacted Files Coverage Δ
src/MentionsInput.js 68.55% <0.00%> (-0.20%) :arrow_down:
src/SuggestionsOverlay.js 64.70% <0.00%> (-1.30%) :arrow_down:
src/Suggestion.js 85.18% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 21005ff...4b728a9. Read the comment docs.

codecov-io avatar Oct 09 '20 12:10 codecov-io

@jfschwarz Can you merge this PR? It's useful.

kaungmyatlwin avatar Dec 14 '21 04:12 kaungmyatlwin

Sorry, I'm no longer maintaining this project.

jfschwarz avatar Dec 14 '21 08:12 jfschwarz

do we have any timeline when this feature will be released?

rimzoni avatar Feb 08 '23 15:02 rimzoni

Thanks @mastrix for this PR - I hope you don't mind if I try to get it merged!

--

Hey @Sigrsig and @steffektif 👋 I think you're the current maintainers as you've merged PRs in this project recently.

Would you be open to merging this if I rebase the PR & add some tests?

jack-lewin avatar Nov 16 '23 12:11 jack-lewin