freeswitch
freeswitch copied to clipboard
signalwire
Chages to include gcs in mod_http_cache
Currently mod_http_cache does not work for Google cloud. This adds support for it.
Scan-build found bugs: https://public-artifacts.signalwire.com/drone/signalwire/freeswitch/238/index.html
![signalwire-ci[bot] avatar](https://avatars.githubusercontent.com/in/27049?v=4 "Published by a pub.dev verified publisher"){kind=small}
Scan-build found bugs: https://public-artifacts.signalwire.com/drone/signalwire/freeswitch/239/index.html
Scan-build found bugs: https://public-artifacts.signalwire.com/drone/signalwire/freeswitch/241/index.html
We'll need some integration tests to accept this new feature. There's a lot of dynamic memory allocations and string manipulation that needs to be run through valgrind/ASAN during CI.
Reviewed latest changes. Still missing tests to accept this.
Yeah haven't had much time to work on this yet. I'll try and get some tests in the coming weeks.
Reviewed latest changes. Still missing tests to accept this.
Yeah haven't had much time to work on this yet. I'll try and get some tests in the coming weeks.
I added some tests looking for a review
Unit-tests compilation failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/470/unit-tests-build-result.txt
Scan-build compilation failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/470/scan-build-result.txt
making all mod_http_cache
make[4]: Entering directory '/drone/src/src/mod/applications/mod_http_cache'
CC mod_http_cache.lo
CC common.lo
mod_http_cache.c: In function 'do_config':
mod_http_cache.c:1706:6: error: 'else' without a previous 'if'
else {
^~~~
Makefile:962: recipe for target 'mod_http_cache.lo' failed
make[4]: *** [mod_http_cache.lo] Error 1
Unit-tests failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/474/artifacts.html
@ovadbar Unit tests failed. There is an overflow. Let me know if you don't have access to the report.
Unit-tests failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/508/artifacts.html
Unit-tests failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/555/artifacts.html
Unit-tests failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/644/artifacts.html
Unit-tests failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/42/artifacts.html
Scan-build found bugs: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/47/index.html
Unit-tests failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/47/artifacts.html
Unit-tests failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/49/artifacts.html
Unit-tests failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/65/artifacts.html
Unit-tests compilation failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/333/unit-tests-build-result.txt
Scan-build compilation failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/333/scan-build-result.txt
Unit-tests failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/504/artifacts.html
Unit-tests failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/505/artifacts.html
Unit-tests failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/530/artifacts.html
Scan-build found bugs: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/530/index.html
Unit-tests failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/896/artifacts.html
Scan-build found bugs: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/896/index.html