freeswitch icon indicating copy to clipboard operation
freeswitch copied to clipboard

[mod_opus] Fix status returned by switch_opus_decode(). Should be SWITCH_STATUS_FALSE instead of SWITCH_STATUS_NOOP. Add a unit-test.

Open andywolk opened this issue 1 year ago • 4 comments

This PR reverts the change made by https://github.com/signalwire/freeswitch/pull/982

andywolk avatar Feb 05 '24 20:02 andywolk

Unit-tests compilation failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/1677/unit-tests-build-result.txt

signalwire-ci[bot] avatar Feb 05 '24 21:02 signalwire-ci[bot]

Scan-build compilation failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/1677/scan-build-result.txt

signalwire-ci[bot] avatar Feb 05 '24 21:02 signalwire-ci[bot]

Unit-tests failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/1678/artifacts.html

signalwire-ci[bot] avatar Feb 05 '24 21:02 signalwire-ci[bot]

Hello,

I agree with the intent in #982 , hanging up on any decoding error is not great. Opus is able to keep decoding the stream if one packet is missing. I think it's better to return SWITCH_STATUS_BREAK as I mentioned in the original PR.

a-rose avatar Feb 12 '24 09:02 a-rose