freeswitch
freeswitch copied to clipboard
new chanvars for inbound multiple header identity
From rfc8224 https://datatracker.ietf.org/doc/html/rfc8224#page-7 Note that unlike the prior specification in [RFC4474], the Identity header field is now allowed to appear more than one time in a SIP request.
depend to libsofia's change: https://github.com/freeswitch/sofia-sip/pull/165
Unit-tests compilation failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/602/unit-tests-build-result.txt
Scan-build compilation failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/602/scan-build-result.txt
Look like the unittest failure error is not related to this change, can you help to review this PR? @andywolk
Scroll up and the issue does appear related:
sofia.c:11503:40: error: assignment to 'sip_identity_t *' {aka 'struct sip_identity_s *'} from incompatible pointer type 'sip_error_t *' {aka 'struct msg_error_s *'} [-Werror=incompatible-pointer-types] for (id = sip->sip_identity; id; id = id->id_next) {
@yois615 It come along with other PR in libsofia: https://github.com/freeswitch/sofia-sip/pull/165 You known how make unittest run with specific version of libsofia?
@hnimminh https://github.com/signalwire/freeswitch/blob/db3dd53aa6a25a3beb821c054f208d2fd6ef02ac/configure.ac#L728
This PR probably cannot be reviewed until the upstream change is merged and the new version is added as a dependency.
Note that I am just a community member and not part of the project maintainer team
Unit-tests failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/912/artifacts.html
Thank you very much @hnimminh