freeswitch icon indicating copy to clipboard operation
freeswitch copied to clipboard

[mod_sofia] Include Callee ID name in presence NOTIFY

Open yois615 opened this issue 3 years ago • 4 comments

Retreive user_data from the switch to display the callee ID name on the endpoint receiving the NOTIFY if it is available

Fixes #1410

yois615 avatar Nov 05 '21 04:11 yois615

Unit-tests failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/492/artifacts.html

signalwire-ci[bot] avatar May 28 '22 00:05 signalwire-ci[bot]

Unit-tests failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/497/artifacts.html

signalwire-ci[bot] avatar May 30 '22 16:05 signalwire-ci[bot]

@Len-PGH

yois615 avatar Jul 05 '22 16:07 yois615

I found a problem but it's somewhat unrelated to this actual code change. The longer display name of Callee ID info in dialog-info+XML can cause the packet to exceed 1514 bytes, and only the first part of the fragmented packet is being sent. Any suggestions how to fix? I'm noticing that the top of the SIP header seems excessive for a NOTIFY:

Allow: INVITE, ACK, BYE, CANCEL, OPTIONS, MESSAGE, INFO, UPDATE, REGISTER, REFER, NOTIFY, PUBLISH, SUBSCRIBE Supported: timer, path, replaces Event: dialog Allow-Events: talk, hold, conference, presence, as-feature-event, dialog, line-seize, call-info, sla, include-session-description, presence.winfo, message-summary, refer

yois615 avatar Jul 13 '22 16:07 yois615

Unit-tests failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/844/artifacts.html

signalwire-ci[bot] avatar Nov 20 '22 19:11 signalwire-ci[bot]

Oh my, IDK why that happened

yois615 avatar Mar 21 '23 17:03 yois615

@andywolk - Looking at the compare it shows a whole bunch of garbage but the commit looks clean. Should I rebase?

yois615 avatar Mar 21 '23 17:03 yois615

Unit-tests failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/1013/artifacts.html

signalwire-ci[bot] avatar Mar 21 '23 17:03 signalwire-ci[bot]