libsignal icon indicating copy to clipboard operation
libsignal copied to clipboard

module documentation tracking issue

Open cosmicexplorer opened this issue 3 years ago • 3 comments

This issue supersedes #285.

#287 adds lots of useful docstrings to the crate, but it is too large by itself to review. We will split it out into smaller PRs and track their progress here.

As per https://github.com/signalapp/libsignal/pull/470#issuecomment-1171539061, I am maintaining a side branch docs-effort on my fork of this repo (https://github.com/cosmicexplorer/libsignal-client/tree/docs-effort) with all of these changes cherry-picked. Each commit has a link to the corresponding PR in its description, and the combined changes can be viewed at https://github.com/signalapp/libsignal/compare/main...cosmicexplorer:libsignal-client:docs-effort?expand=1.

TODO

  • [x] #289
  • [x] #476
  • [x] #472
  • [x] #468
  • [ ] #471
  • [ ] #473
  • [ ] #474
  • [ ] #475
  • [x] #470

Closed

  • [x] #466
    • Closed: decided against this change.
  • [x] #469
    • Closed: to be implemented upstream in zkcrypto/subtle-ng#5.

cosmicexplorer avatar Jun 27 '22 03:06 cosmicexplorer

@jrose-signal I've chosen to tag each commit on docs-effort with the pull request it's from: see the collected changes at https://github.com/signalapp/libsignal/compare/main...cosmicexplorer:libsignal-client:docs-effort?expand=1. This means that you can quickly verify that each corresponding PR has been accepted before cherry-picking each commit. Each PR in the above list has been squashed to a single commit.

cosmicexplorer avatar Jul 19 '22 00:07 cosmicexplorer

could you provide link on documentation or some examples of usage: how to use java client?

okryvokoniev avatar Jul 19 '23 10:07 okryvokoniev

could you provide link on documentation or some examples of usage: how to use java client?

In the absence of documents or examples you can refer to https://github.com/signalapp/signal-android for the actual uses of libsignal's Java interface.

moiseev-signal avatar Jul 21 '23 23:07 moiseev-signal