libsignal-service-java

libsignal-service-java copied to clipboard

Increase socket read/write buffer size for better performance while uploading/downloading large attachments

1

Currently, the code uses a buffer of 4096 bytes when uploading or downloading attachments. I am not 100% sure if it is because of this, but attachment upload/download performance is...

NFM-8

Adjust primitive names to match JCE built-ins

1

The recent versions of Java (e.g. 8) already have the requisite ciphers and the dependency can be eliminated.

blackgnezdo

Current code is not compatible with code in Contact Discovery Service (CDS)

6

Hi! CDS requires libsignal-service-java version 2.7.8, but there is only verion 2.15.0 of libsignal-service-java available or 1.8.6(by tags). 2.15.0 has incomaptible class interface. Let's decide how to resolve this issue.

kvishnivetsky

It should not be possible to add yourself to a group without invitation

2

Although this is security related, it has already been publicized and is public knowledge. This article: https://blog.cryptographyengineering.com/2018/01/10/attack-of-the-week-group-messaging-in-whatsapp-and-signal/ explains an issue in Signal where anyone could in theory invite themselves to...

Meteor0id

I dont know if preauth is mandatory to hook app and server together, it seems so. since this path is added in July but the latest commit of server code...

maincui

Unable to upload attachments

1

Hi Team, I am unable to upload attachments using an android client. Its throwing `http 405` error code while calling `uploadtoCdn `function. ``` org.whispersystems.signalservice.api.push.exceptions.NonSuccessfulResponseCodeException: Response: Response{protocol=h2, code=405, message=, url=https://cdn.xxxx.com/attachments/} at...

sbhushan87

``` /usr/lib/jvm/java-12-openjdk/bin/java -javaagent:/opt/intellij-idea-ultimate-edition/lib/idea_rt.jar=38037:/opt/intellij-idea-ultimate-edition/bin -Dfile.encoding=UTF-8 -classpath /home/magnus/Documents/code/jahnenb1/service.signal/out/production/classes:/home/magnus/Documents/code/jahnenb1/service.signal/out/production/resources:/home/magnus/.gradle/caches/modules-2/files-2.1/org.eclipse.paho/org.eclipse.paho.client.mqttv3/1.2.1/a0932397520960d23566d1d9d09075f28bc8164/org.eclipse.paho.client.mqttv3-1.2.1.jar:/home/magnus/.gradle/caches/modules-2/files-2.1/org.whispersystems/signal-service-java/2.13.4/1dd89230f61f03d3dab5d5b942c49bb7be3eacc0/signal-service-java-2.13.4.jar:/home/magnus/.gradle/caches/modules-2/files-2.1/com.xenomachina/kotlin-argparser/2.0.7/421316b02a8a882dc2af32b7d57caa3c5ce30267/kotlin-argparser-2.0.7.jar:/home/magnus/.gradle/caches/modules-2/files-2.1/org.bouncycastle/bcprov-jdk15on/1.62/633b6739ef8f07f2e71f8eebd1c6f25b17a4ec7d/bcprov-jdk15on-1.62.jar:/home/magnus/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib-jdk8/1.3.21/d0634d54452abc421db494ad32dd215e6591c49f/kotlin-stdlib-jdk8-1.3.21.jar:/home/magnus/.gradle/caches/modules-2/files-2.1/org.signal/signal-metadata-java/0.0.3/5fd094180d431f902e8a2fc0899831234d11cec1/signal-metadata-java-0.0.3.jar:/home/magnus/.gradle/caches/modules-2/files-2.1/org.whispersystems/signal-protocol-java/2.7.1/6bdfd005dc679334cbbbb8b0ee24eceb131f5093/signal-protocol-java-2.7.1.jar:/home/magnus/.gradle/caches/modules-2/files-2.1/com.google.protobuf/protobuf-java/2.5.0/a10732c76bfacdbd633a7eb0f7968b1059a65dfa/protobuf-java-2.5.0.jar:/home/magnus/.gradle/caches/modules-2/files-2.1/com.googlecode.libphonenumber/libphonenumber/8.10.7/5fe2639a6777014b9116f515c80fa09c92075c64/libphonenumber-8.10.7.jar:/home/magnus/.gradle/caches/modules-2/files-2.1/com.fasterxml.jackson.core/jackson-databind/2.9.8/11283f21cc480aa86c4df7a0a3243ec508372ed2/jackson-databind-2.9.8.jar:/home/magnus/.gradle/caches/modules-2/files-2.1/com.squareup.okhttp3/okhttp/3.12.1/dc6d02e4e68514eff5631963e28ca7742ac69efe/okhttp-3.12.1.jar:/home/magnus/.gradle/caches/modules-2/files-2.1/org.threeten/threetenbp/1.3.6/89dcc04a7e028c3c963413a71f950703cf51f057/threetenbp-1.3.6.jar:/home/magnus/.gradle/caches/modules-2/files-2.1/com.xenomachina/xenocom/0.0.7/45b60f19517d3085c9763b83c00f6778b2a8cec/xenocom-0.0.7.jar:/home/magnus/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib-jdk7/1.3.21/d207ce2c9bcf17dc8e51bab4dbfdac4d013e7138/kotlin-stdlib-jdk7-1.3.21.jar:/home/magnus/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib/1.3.21/4bcc2012b84840e19e1e28074284cac908be0295/kotlin-stdlib-1.3.21.jar:/home/magnus/.gradle/caches/modules-2/files-2.1/com.fasterxml.jackson.core/jackson-annotations/2.9.0/7c10d545325e3a6e72e06381afe469fd40eb701/jackson-annotations-2.9.0.jar:/home/magnus/.gradle/caches/modules-2/files-2.1/com.fasterxml.jackson.core/jackson-core/2.9.8/f5a654e4675769c716e5b387830d19b501ca191/jackson-core-2.9.8.jar:/home/magnus/.gradle/caches/modules-2/files-2.1/com.squareup.okio/okio/1.15.0/bc28b5a964c8f5721eb58ee3f3c47a9bcbf4f4d8/okio-1.15.0.jar:/home/magnus/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib-common/1.3.21/f30e4a9897913e53d778f564110bafa1fef46643/kotlin-stdlib-common-1.3.21.jar:/home/magnus/.gradle/caches/modules-2/files-2.1/org.jetbrains/annotations/13.0/919f0dfe192fb4e063e7dacadee7f8bb9a2672a9/annotations-13.0.jar:/home/magnus/.gradle/caches/modules-2/files-2.1/org.whispersystems/curve25519-java/0.5.0/787dab46ed8e6f8adf9bbbb945145d503b7f181a/curve25519-java-0.5.0.jar me.jahnen.service.signal.signal.RegisterKt --name +14136246876 Exception in thread "main" java.lang.NullPointerException: No password supplied for PKCS#12 KeyStore. at org.bouncycastle.jcajce.provider.keystore.pkcs12.PKCS12KeyStoreSpi.engineLoad(Unknown Source) at java.base/java.security.KeyStore.load(KeyStore.java:1472) at java.base/sun.security.ssl.TrustStoreManager$TrustAnchorManager.loadKeyStore(TrustStoreManager.java:365) at java.base/sun.security.ssl.TrustStoreManager$TrustAnchorManager.getTrustedCerts(TrustStoreManager.java:313) at...

magnusja

Last resort key still in documentation

3

https://github.com/signalapp/libsignal-protocol-java/commit/111df84ac05ac4cd1fe98c0b9e64335eeac83122 removed the Last Resort Pre Key, but it's still mentioned in the documentation/README.md of this git repository.

bneijt

Uploading attachments over an unreliable mobile network often fails for me due to this timeout, hence I propose it is increased.

petcap

I apologize in advance for the length of this message, but I've tried to be as thorough as possible in documenting this issue. To make review easier, I've split the...

dpapavas