libsignal-service-java icon indicating copy to clipboard operation
libsignal-service-java copied to clipboard

Published 20 hours ago • verified publisher icon signalapp

License not clear

Open michaelforney opened this issue 7 years ago • 4 comments

The LICENSE file contains the GPLv3, but README.md says it is licensed under the AGPLv3. These two should be reconciled.

michaelforney avatar Jul 29 '17 06:07 michaelforney

This seems like an important thing to clear up.

michaelforney avatar Oct 02 '17 17:10 michaelforney

@moxie0 hello, I'm in the process of packaging this library for Debian GNU/Linux and would be very grateful if you could clarify what seems to be a minor inconsistency. Thanks in advance for this and even more for making Signal Free Software !

ghost avatar Feb 20 '18 15:02 ghost

Still needs fixing. The README.md was updated in 2015 to say AGPLv3, https://github.com/signalapp/libsignal-service-java/commit/e02aea9cfb440b6cf88e6444a4c6bcad2991bc97#diff-04c6e90faac2675aa89e2176d2eec7d8 but the build.gradle and the LICENSE file have always said GPLv3. Logically, because signal4android is definitely GPLv3, since it is a combined work with libsignal-service-java, that means the correct license here is GPLv3. Please change this pair of lines:

  • https://github.com/signalapp/libsignal-service-java/blob/master/README.md

  • Copyright 2013-2016 Open Whisper Systems
  • Licensed under the AGPLv3: https://www.gnu.org/licenses/agpl-3.0.html

To the correct values. My guess would be it should nowadays be saying:

  • Copyright 2013-2017 Open Whisper Systems.
  • Copyright 2018-2019 Signal Foundation
  • Licensed under the GPLv3: https://www.gnu.org/licenses/gpl-3.0.html

Diff with 3 deletions and 2 insertions:

I can make a PR if that will help

five-c-d avatar Jul 31 '19 22:07 five-c-d

The README does not seem to be the only issue, some files have an Affero-specific header:

rsmet on nas in libsignal-service-java on  master [📝] via ☕ v1.8.0
❯ rg Affero                                                                                                                                Fri 10 Jul 2020 07:54:01 AM UTC
LICENSE
552:  13. Use with the GNU Affero General Public License.
556:under version 3 of the GNU Affero General Public License into a single
559:but the special requirements of the GNU Affero General Public License,

java/src/main/java/org/whispersystems/signalservice/internal/contacts/entities/DiscoveryResponse.java
5: * it under the terms of the GNU Affero General Public License as published by
12: * GNU Affero General Public License for more details.
14: * You should have received a copy of the GNU Affero General Public License

java/src/main/java/org/whispersystems/signalservice/internal/contacts/entities/RemoteAttestationRequest.java
5: * it under the terms of the GNU Affero General Public License as published by
12: * GNU Affero General Public License for more details.
14: * You should have received a copy of the GNU Affero General Public License

java/src/main/java/org/whispersystems/signalservice/internal/contacts/entities/DiscoveryRequest.java
5: * it under the terms of the GNU Affero General Public License as published by
12: * GNU Affero General Public License for more details.
14: * You should have received a copy of the GNU Affero General Public License

java/src/main/java/org/whispersystems/signalservice/internal/contacts/entities/RemoteAttestationResponse.java
5: * it under the terms of the GNU Affero General Public License as published by
12: * GNU Affero General Public License for more details.
14: * You should have received a copy of the GNU Affero General Public License

rubdos avatar Jul 10 '20 08:07 rubdos