Clamped Disppearing Messages to 4 Weeks

[MarlowBrown]

Contributor checklist

• [x] My commits are rebased on the latest main branch
• [x] My commits are in nice logical chunks
• [x] My contribution is fully baked and is ready to be merged as is
• [x] I have tested my contribution on these devices:

• iPhone 16, iOS 18.2

---

Description

This pull request fixes #5947 by clamping an internal value in the Disappearing Messages Timers picker to 4 weeks.

[sashaweiss-signal]

Hi @MarlowBrown,

While I'm guessing this workaround works for the specific case of handling too-many weeks, it feels like we shouldn't need to be clamping. Instead, it feels like when the unit is changed (e.g., from days to weeks), and the maximum selectable number of units is clamped in the UI (e.g., from some number of days to "4", for weeks), that the new "selected" unit should be propagated back to the view controller by the CustomTimePicker.

[MarlowBrown]

Update for you @sashaweiss-signal

I changed the code to avoid clamping. The change is a little weird as technically until the user has moved the picker wheel, it doesn't count as "selected". I think it might be by design, so the code for force selecting is warranted.

[github-actions[bot]]

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[dihv]

Looks good to me

[sashaweiss-signal]

Hey @MarlowBrown, thanks for the contribution. I ended up rebuilding this view, and in the process addressed the clamping issue.

The rebuild is in 65dccf9f42, which should become public with an upcoming release.

[MarlowBrown]

Sounds good. Thank you for keeping me updated! Check out my other PRs btw ;)