signalapp
#5837 Disappearing Navigation Bar
First time contributor checklist
- [x] I have read the README and CONTRIBUTING documents
- [x] I have signed the Contributor Licence Agreement
Contributor checklist
- [x] My commits are rebased on the latest main branch
- [x] My commits are in nice logical chunks
- [x] My contribution is fully baked and is ready to be merged as is
- [x] I have tested my contribution on these devices:
- iPhone 16, iOS 18.2
- iPad Pro 13-inch M4, iOS 18.2
Description
This proposal fixes #5837 by provided a workaround the navigation bar disappearing. Exploring the codebase, there is no location where the navigation bar title view is hidden; however, as explained in the code comment in this PRs only commit, I am confident that this is a UIKit bug. This PR is a workaround until that UIKit bug is patched.
I'm not wild about adding this workaround.
I can't trivially reproduce the issue on iOS 18.3 by rotating to landscape and back, so clearly something unreliable is going on. There's already a lot of unstable and hacky things already around Signal's nav bars, and I'm not inclined to add yet another instance without understanding the root cause. I worry that this will create more subtle problems down the line.
Unfortunately, I don't think this is the way we'd want to address this, so I'm going to close this PR. Thanks for looking into it, and I'll keep this approach in mind the next time I take a look into this issue.