Signal-iOS icon indicating copy to clipboard operation
Signal-iOS copied to clipboard

Prevent video stop in MediaPageViewController when new attachment arrives.

Open alex1704 opened this issue 10 months ago • 0 comments

First time contributor checklist

Contributor checklist

  • [x] My commits are rebased on the latest main branch
  • [x] My commits are in nice logical chunks
  • [x] My contribution is fully baked and is ready to be merged as is
  • [x] I have tested my contribution on these devices:
  • iPhone 7, iOS 15.7.9

Description

When user opens video attachment, MediaPageViewController presents it and play it. If in this moment user receives new attachment - audio or video then video stops playing. Solution is to reload attachment only if it is different then current one.

Steps to reproduce: Assuming that phone1 received video attachment (say 20 seconds long) at some point

  1. on phone1 open mentioned video attachment
  2. on phone2 send to phone1 photo or audio message
  3. video on phone1 stops playing

alex1704 avatar Apr 04 '24 20:04 alex1704