Signal-iOS icon indicating copy to clipboard operation
Signal-iOS copied to clipboard

Double tap message to show context menu

Open kevinmbeaulieu opened this issue 11 months ago • 1 comments

First time contributor checklist

Contributor checklist

  • [x] My commits are rebased on the latest main branch
  • [x] My commits are in nice logical chunks
  • [x] My contribution is fully baked and is ready to be merged as is
  • [x] I have tested my contribution on these devices:
  • iPhone 14 Pro, iOS 17.4

Description

In the conversation view, long pressing a message presents the context view for that cell, allowing the user to add reactions, reply, delete the message, etc. To match the behavior that iOS users are accustomed to in iMessage, Signal should also allow double-tapping messages to present this menu. This can also be faster, since double-tapping doesn't have the same time delay that long press gestures have.

The code changes implemented all followed the same patterns as the tap and long press gesture recognizers on that view, so even though it's a few hundred lines it's mostly copy-paste from that and just tweaking the relevant parts.

kevinmbeaulieu avatar Mar 16 '24 01:03 kevinmbeaulieu

can't comment on the code, but this would be a good feature to have for sure

great work

tohrxyz avatar Mar 31 '24 18:03 tohrxyz

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 29 '24 18:06 stale[bot]

This issue has been closed due to inactivity.

stale[bot] avatar Jul 07 '24 12:07 stale[bot]