Signal-iOS icon indicating copy to clipboard operation
Signal-iOS copied to clipboard

Published 20 hours ago • verified publisher icon signalapp

Ability to select all media in selection mode

Open phraemer opened this issue 1 year ago • 7 comments

First time contributor checklist

Contributor checklist

  • [x] My commits are rebased on the latest main branch
  • [x] My commits are in nice logical chunks
  • [x] My contribution is fully baked and is ready to be merged as is
  • [x] I have tested my contribution on these devices:
  • iPhone 13, iOS 17.0.3
  • Simulator iPhone 15, iOS 17.0

Description

When deleting media it can take an extraordinary amount of time to select all items to delete as there is currently no way to select all. This is not only inconvenient but impacts user security when it may be necessary to delete all media from a conversation quickly without losing the text of the conversation. It's also a very common UI pattern to be able to select all items.

This PR adds a text button to the task bar allowing the user in one tap to select all the items in the view. When any items are selected the text of the buttons allows the user to select none. The button is placed on the left away from the Delete button to prevent any accidental presses.

https://github.com/signalapp/Signal-iOS/assets/143631/c40f9fcd-9fca-4b83-ad82-ce24c3b9b95d

phraemer avatar Oct 16 '23 21:10 phraemer

I hope that this welcome feature is added in short notice, since a lot of users are struggling with cleansing their media in Signal!

Excelbrains avatar Nov 29 '23 12:11 Excelbrains

Please merge this asap, a lot of people needs this

iSack97 avatar Jan 14 '24 17:01 iSack97

Belated happy new year to the Signal team 😚🎉

How are we looking at getting this in? It will help so many people!

phraemer avatar Feb 06 '24 16:02 phraemer

@harry-signal please please please can we get this merged? It's so frustratingly difficult and time consuming to manage storage space in Signal on iOS and this will be such a huge help for such a small change.

phraemer avatar Mar 19 '24 09:03 phraemer

+1 hoping for this to come asap

tohrxyz avatar Mar 31 '24 18:03 tohrxyz

I am absolutely begging you to get this in please! It's utterly impractical to manually select items for what are now years of stuff in a chat.

@harry-signal ... anyone? Just let me know what I can do to move this simple but incredibly useful change forward.

Thanks.

phraemer avatar Jun 06 '24 12:06 phraemer

I know devs are working on other backup functionality, but this is a fucking joke. They just need to push this and a lot of people would have easier lifes

iSack97 avatar Aug 09 '24 13:08 iSack97