Signal-iOS
Signal-iOS copied to clipboard
Link containing two #s is not clickable
- [x] I have searched open and closed issues for duplicates (I could find other link edge cases that are either already fixed, stale or both)
- [x] I am submitting a bug report for existing functionality that does not work as intended
- [x] This isn't a feature request or a discussion topic
Bug description
Describe here the issue that you are experiencing.
Steps to reproduce
- Send or receive a link containing https://example.com/#/hello or https://example.com/#/hello/#world or otherwise a message with a similar format.
Actual result: Link is not clickable
Expected result: Link is clickable
Screenshots
Device info
Device: iPhone 6s
iOS version: 15.7.8
Signal version: 6.43.0.10
Link to debug log
https://debuglogs.org/ios/6.43.0/fc74a0034212a27cc4d4c24f0a3cd9b4e1d1158c84c3a2a14d1afd78f16a8885.zip
It doesn’t seem to be a Signal-specific problem. Signal uses a link detector embedded in UIKit/Swift or something:
NSTextCheckingResult.CheckingType.link.rawValue:
https://github.com/signalapp/Signal-iOS/blob/2d6fee16cd92cedf20eafaa3908df0be32d4e9b3/Signal/src/util/DisplayableText.swift#L129
(If this is wrong, please correct me)
Hi @gabrc52,
Is there a valid URL with two #s that does not linktify? The one provided is just an example domain.
This URL is valid, but it's uncommon.
Yes, links to Matrix rooms have this format: https://matrix.to/#/#matrix:matrix.org
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Don‘t close
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Unstale
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Unstale
Best, Gabriel
From: stale[bot] @.> Sent: Sunday, July 21, 2024 3:45:33 AM To: signalapp/Signal-iOS @.> Cc: Gabriel R Rodriguez Castillo @.>; Mention @.> Subject: Re: [signalapp/Signal-iOS] Link containing two #s is not clickable (Issue #5675)
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
— Reply to this email directly, view it on GitHubhttps://github.com/signalapp/Signal-iOS/issues/5675#issuecomment-2241513626, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFZ4HIXHHNEDP7XGI2ESIQDZNNRJ3AVCNFSM6AAAAAA5OAFMAKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBRGUYTGNRSGY. You are receiving this because you were mentioned.Message ID: @.***>
Unstaling this won’t help with fixing it