Menu bar and menus: access keys / mnemonics/accelerators are not underlined/visible in dark mode

[Chealer]

Many of Signal 7.43.0's 5 top menus (in its menu bar) themselves and their items have access keys. For example, in French, the second menu (Édition) is accessed on Microsoft Windows with Alt+d, since "d" is the second character of the menu's name.

Unfortunately, all of these mnemonics are hidden (not visible). None of letters of the menu names and item names are underlined, so users have to guess access keys, as can be seen in the following screenshot:

Fortunately, several commands have keyboard shortcuts, which are properly displayed in the menu, and the menus can be browsed with arrow keys. For example, one who doesn't know that the Aide (Help) menu has "i" as access key could press Alt, →, →, →, →, ↓.

This occurs on Microsoft Windows 11 (24H2).

[sashaweiss-signal]

Hi @MarlowBrown,

While I'm guessing this workaround works for the specific case of handling too-many weeks, it feels like we shouldn't need to be clamping. Instead, it feels like when the unit is changed (e.g., from days to weeks), and the maximum selectable number of units is clamped in the UI (e.g., from some number of days to "4", for weeks), that the new "selected" unit should be propagated back to the view controller by the CustomTimePicker.

[MarlowBrown]

Update for you @sashaweiss-signal

I changed the code to avoid clamping. The change is a little weird as technically until the user has moved the picker wheel, it doesn't count as "selected". I think it might be by design, so the code for force selecting is warranted.

[github-actions[bot]]

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[dihv]

Looks good to me

[sashaweiss-signal]

Hey @MarlowBrown, thanks for the contribution. I ended up rebuilding this view, and in the process addressed the clamping issue.

The rebuild is in 65dccf9f42, which should become public with an upcoming release.

[MarlowBrown]

Sounds good. Thank you for keeping me updated! Check out my other PRs btw ;)