Signal-Desktop icon indicating copy to clipboard operation
Signal-Desktop copied to clipboard

update chmod command

Open crd477 opened this issue 1 year ago • 1 comments

First time contributor checklist:

Contributor checklist:

  • [x] My contribution is not related to translations.
  • [x] My commits are in nice logical chunks with good commit messages
  • [x] My changes are rebased on the latest main branch
  • [x] A npm run ready run passes successfully (more about tests here)
  • [x] My changes are ready to be shipped to users

Description

There is a small error in the instructions for reproducible builds. The chmod instructions include the public tag meant for the ./build.sh command in the next step, but public is not a file or directory:

$ chmod +x ./build.sh public
chmod: cannot access 'public': No such file or directory

crd477 avatar Sep 05 '24 12:09 crd477

Thanks for catching this and submitting a fix! We've merged it internally and it will be available with the next beta release.

ayumi-signal avatar Sep 05 '24 17:09 ayumi-signal

So this PR can be closed ?

AnonAlly avatar Feb 24 '25 21:02 AnonAlly

Yes, it's been merged now. Thanks for the reminder!

ayumi-signal avatar Feb 24 '25 22:02 ayumi-signal