Signal-Android icon indicating copy to clipboard operation
Signal-Android copied to clipboard

Fix pasting an image into an edited message instead of sending a new copy

Open UnreachableCode opened this issue 8 months ago • 0 comments

First time contributor checklist

Contributor checklist

  • Pixel 8, Android 15.
  • [x] My contribution is fully baked and ready to be merged as is
  • [x] I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

I think when the edit message feature was added, the ability to paste an image into the editing message was overlooked. Worth noting that this same bug also exists in the iOS application. I will not be fixing the iOS bug at this time.

For the fix, I've added the edit message ID into ConversationFragment.sendPreUploadMediaMessage(...) for the messageToEdit parameter. This is how it's done in the regular text send. I tested it with several messages in a chat and it now edits the existing message instead of sending a fresh one.

UnreachableCode avatar Mar 30 '25 18:03 UnreachableCode