Signal-Android icon indicating copy to clipboard operation
Signal-Android copied to clipboard

Fixes #14051: Preserve search term when refreshing contacts

Open codewithdipesh opened this issue 8 months ago • 1 comments

First time contributor checklist

Contributor checklist

  • Device A, Android X.Y.Z
  • Device B, Android Z.Y
  • Virtual device W, Android Y.Y.Z
  • [x] My contribution is fully baked and ready to be merged as is
  • [x] I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

The fix is straightforward - I've removed the line in RefreshDirectoryTask.onPostExecute() that was explicitly clearing the search field activity.contactFilterView.clear(), while maintaining the call to reset the query filter. This allows the contacts to refresh properly while preserving the user's search term.

I tested the fix by: -starting a new chat -Searching for the contact by name (not found initially) -Clicking "refresh contacts" -Verifying the search term remained in the search field -Confirming the newly added contact appears in the filtered results after refresh

The fix was tested on a Pixel 7 Pro running Android 15 with Signal version 7.38.5

codewithdipesh avatar Mar 22 '25 19:03 codewithdipesh

Thanks! this was pulled into 7.39

alex-signal avatar Mar 24 '25 12:03 alex-signal

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 25 '25 05:05 stale[bot]