Signal-Android icon indicating copy to clipboard operation
Signal-Android copied to clipboard

Hide schedules Media from ConversationSettings

Open Sagar0-0 opened this issue 10 months ago • 0 comments

First time contributor checklist

Contributor checklist

  • Device A, Android X.Y.Z
  • Device B, Android Z.Y
  • Virtual device W, Android Y.Y.Z
  • [x] My contribution is fully baked and ready to be merged as is
  • [x] I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

Reasons for doing this:

  1. Schedules messages are not logically "shared" in the thread.
  2. We can go to the Media Preview Screen for Scheduled Image, which can allow us to delete a schedule message for everyone. So, possibility of a Deleted message is still scheduled.
  3. A scheduled media message is present in the MediaOverview, from where we can select and delete it, this cause inconsistencies with the scheduled message flow.
  4. Schedules Media message show the System.currentTimeMillis date for the media in MediaOverview screen but actually the media isn't sent yet! photo_6134124661139685546_y

So, now showing the Scheduled media is probably the best choice which other Messengers like Telegram also follow.

https://github.com/user-attachments/assets/2ac1ce5b-2ddd-4803-81dd-ac09e39b5c31

Sagar0-0 avatar Feb 05 '25 17:02 Sagar0-0